Repository navigation
[networkx] Use concrete node types for a few generators - #16603
Merged
Merged
Conversation
…triad_graph and visibility_graph
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These generators always produce integer or string nodes, so their return types now say so instead of using
Incomplete:mycielskianrelabels withconvert_node_labels_to_integers(upstream),mycielski_graphbuilds onempty_graph/path_graphandmycielskian(upstream),visibility_graphstarts frompath_graph(len(series))(upstream), andtriad_graphadds the nodes"abc"(upstream).Written with Claude Code (an AI coding agent).