Repository navigation
[email] contains_token_type was backported to 3.11-3.13 - #16624
Open
hoangchunghien wants to merge 1 commit into
Open
hoangchunghien wants to merge 1 commit into
hoangchunghien wants to merge 1 commit into
Conversation
Python 3.11.18, 3.12.16 and 3.13.18 add TokenList.contains_token_type and Terminal.contains_token_type, which python#16596 added for 3.14.9 and 3.15.1. The daily stubtest run fails on the Ubuntu runners, which already have these releases (python#16622). macOS and Windows runners are still on older patches, so the darwin and win32 allowlists carry temporary entries until they update.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16596 added
TokenList.contains_token_typeandTerminal.contains_token_typebehindsys.version_info >= (3, 14), for 3.14.9 and 3.15.1. CPython has since backported them to 3.11.18, 3.12.16 and 3.13.18. The previous patch on each branch doesn't have them:def contains_token_typeis absent fromLib/email/_header_value_parser.pyatv3.11.17,v3.12.15andv3.13.17, and present at the three tags above. 3.10 doesn't have it.That's the stdlib half of last night's failure (#16622). Only the Ubuntu jobs fail, because they already run 3.11.18, 3.12.16 and 3.13.18. The macOS runners are still on 3.11.9 and 3.12.10, and Windows passes too.
This changes:
sys.version_info >= (3, 11), with the comment listing all five releases;darwin-py311/312/313.txtandwin32-py311/312/313.txt, each gaining a temporary block in the existing "Remove once 3.x.y becomes available for GitHub Actions" form.win32-py313anddarwin-py313had no Temporary section, so I added one at the top as in the py311/py312 files.Checked in Docker:
python:3.13.18-slimandpython:3.12.16-slim, fulltests/stubtest_stdlib.py: no errors foremail(the only errors aretkinter,turtle,_tkinterand onesocketitem, from the slim images lacking Tk).python:3.13.15-slim, standing in for the older macOS/Windows patches: stubtest onemail._header_value_parserreports the two methods as not present at runtime, and passes with the new allowlist entries.mypy_test.py stdlib/email,check_typeshed_structure.py, flake8 and black pass.No 3.11.18 image is published, so 3.11 rests on the CPython tags and the Ubuntu CI run.
Refs #16622 (the third-party half is #16623).