You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(sdk): change the members empty state copy for filtered results - #2032
Updated the members table’s empty-state message to clarify that no members match the selected filters and suggest adjusting or clearing them.
The members table empty-state subheading now says that no members match the selected filters and suggests adjusting or clearing them. It replaces the prompt to add a first member.
Empty member lists can incorrectly tell users to adjust filters, and whitespace-only searches can leave the table difficult to recover. These are bounded issues to fix or explicitly accept before merging.
Pre-merge checks: 2
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
Minor · Functional Correctness · Quick win
Handle whitespace-only searches in the zero state.
When a search contains only spaces and matches no rows, Apsara treats it as an inactive query but still filters the rows. This branch then shows the onboarding message. Apsara also disables the search input, so the user cannot edit it or use the new clear button. (raw.githubusercontent.com)
Handle this case in both member tables, including project-details-view.tsx at Line 377. Keep search editable and distinguish a whitespace search from an empty member list, or normalize whitespace consistently before filtering.
The members table shows its empty state when the filters match no members, so the onboarding text did not fit. The table already adds the clear filters action.
rohanchkrabrty
changed the title
fix(sdk): show a filter empty state when no members match
fix(sdk): change the members empty state copy for filtered results
Oct 30, 2026
The reason will be displayed to describe this comment to others. Learn more.
Follow-up Comments
Use the role filter state to choose the zero-state copy.
190-190: Minor · Functional Correctness · Quick win
Use the role filter state to choose the zero-state copy.
zeroState takes priority over emptyState when no rows remain and no table query is active. The role Select is local state. It filters data before DataTable receives it, so it never reaches tableQuery. Adding onboarding copy as zeroState alone would show "Get started by adding your first member" when a selected role has no members.
The current code shows the filter copy for every empty result. That includes an empty result with roleFilter === 'all', which has no active filter. Show the onboarding copy only in that case.
Suggested fix
+ const filteredEmptyState = (+ <EmptyState+ icon={<ExclamationTriangleIcon />}+ heading="No members found"+ subHeading="No members match the selected filters. Try adjusting or clearing your filters."+ />+ );+
return (
<DataTable.Content
+ zeroState={+ roleFilter === 'all' ? (+ <EmptyState+ icon={<ExclamationTriangleIcon />}+ heading="No members found"+ subHeading="Get started by adding your first member"+ />+ ) : (+ filteredEmptyState+ )+ }
emptyState={
- <EmptyState- icon={<ExclamationTriangleIcon />}- heading="No members found"- subHeading="No members match the selected filters. Try adjusting or clearing your filters."- />+ filteredEmptyState
}
Reviewing files that changed from the base of the PR and between c24ac8a and 34ba60b.
Files selected for processing: 1
web/sdk/client/views/members/members-view.tsx
Files skipped from review as they are similar to previous changes: 1
web/sdk/client/views/members/members-view.tsx
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary