Repository navigation
fix(sdk): add a cancel button to the delete domain dialog - #2033
rohanchkrabrty wants to merge 1 commit into
Conversation
The delete domain dialog had only the delete button, so users could not go back to the security page without a refresh. Add a Cancel button that closes the dialog, the same as the delete organization dialog. Cancel stays visible while the domain loads and is disabled while the delete is pending.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Cancel button behavior web/sdk/client/views/security/components/delete-domain-dialog.tsx |
The Cancel button is rendered through AlertDialog.Close and is disabled while deletion is pending. |
Priority:
Estimated code review effort: 1 (Trivial) | ~5 minutes
Change: Bug fix
Possibly related PRs
- raystack/frontier#2025: This PR applies the AlertDialog pattern to the delete organization dialog’s Cancel button.
Suggested reviewers: rohilsurana
Merge Risk: 
45ba8
-
The requested cancel behavior is implemented without an established correctness or availability risk.
Pre-merge checks: 
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Coverage Report for CI Build 41015375773Coverage remained the same at 55.992%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
AlertDialog.Closewith an outline neutralButton, the same pattern as the delete organization dialog. It closes the dialog without a delete call, and it is disabled while the delete is pending.