Skip to content

fix: include links with an empty href in focus list #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aminark wants to merge 2 commits into
base: master
from
Open

fix: include links with an empty href in focus list #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
749319c
fix: include links with an empty href in focus list
Oct 25, 2026
61b0090
test: cover empty href and negative tabindex
Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Dom/focus.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function focusable(node: HTMLElement, includePositive = false): boolean {
// Editable element
node.isContentEditable ||
// Anchor with href element
(nodeName === 'a' && !!node.getAttribute('href'));
(nodeName === 'a' && node.hasAttribute('href'));

// Get tabIndex
const tabIndexAttr = node.getAttribute('tabindex');
Expand Down
19 changes: 19 additions & 0 deletions tests/focus.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,25 @@ describe('focus', () => {
setSelectionRangeSpy.mockRestore();
});

it('includes links with an empty href in the focus list', () => {
const container = document.createElement('div');
container.innerHTML = '<a href="">current page</a><a>placeholder</a>';
document.body.appendChild(container);
const link = container.querySelector('a');

try {
link.focus();
expect(document.activeElement).toBe(link);
expect(getFocusNodeList(container)).toEqual([link]);

link.tabIndex = -1;
expect(getFocusNodeList(container)).toEqual([]);
expect(getFocusNodeList(container, true)).toEqual([link]);
} finally {
container.remove();
}
});

describe('useLockFocus', () => {
const TestComponent: React.FC<{ lock: boolean }> = ({ lock }) => {
const elementRef = useRef<HTMLDivElement>(null);
Expand Down