Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/demo/scrollbar-percentage-regression.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
title: Scrollbar percentage regression
nav:
title: Demo
path: /demo
---

<code src="../../examples/scrollbar-percentage-regression.tsx"></code>
80 changes: 80 additions & 0 deletions examples/scrollbar-percentage-regression.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
import * as React from 'react';
import List from '../src/List';

const data = [{ id: 'first' }, { id: 'second' }];

export default function ScrollbarPercentageRegression() {
const [layoutResult, setLayoutResult] = React.useState('Checking layout…');

React.useLayoutEffect(() => {
const root = document.querySelector<HTMLElement>('#percentage-gutter-list');
const holder = root?.querySelector<HTMLElement>('.rc-virtual-list-holder');
const horizontalTrack = root?.querySelector<HTMLElement>(
'.rc-virtual-list-scrollbar-slot-horizontal',
);

if (!root || !holder || !horizontalTrack) {
setLayoutResult('FAIL: expected list, holder, and horizontal track');
return undefined;
}

let frame = 0;
const verifyLayout = () => {
const holderBounds = holder.getBoundingClientRect();
const rows = Array.from(holder.querySelectorAll<HTMLElement>('[data-regression-row]'));
const bothRowsVisible =
rows.length === 2 &&
rows.every((row) => {
const bounds = row.getBoundingClientRect();
return bounds.top >= holderBounds.top && bounds.bottom <= holderBounds.bottom;
});
const gutterStartsAfterHolder =
Math.abs(holderBounds.bottom - horizontalTrack.getBoundingClientRect().top) < 1;
const hasNoVerticalGutter = !root.querySelector('.rc-virtual-list-scrollbar-slot-vertical');

setLayoutResult(
bothRowsVisible && gutterStartsAfterHolder && hasNoVerticalGutter
? 'PASS: both rows fit above the horizontal gutter, with no vertical gutter'
: 'FAIL: percentage gutter reduces or overlaps the short list viewport',
);
};

const observer = new ResizeObserver(() => {
cancelAnimationFrame(frame);
frame = requestAnimationFrame(verifyLayout);
});
observer.observe(root);
observer.observe(holder);
frame = requestAnimationFrame(verifyLayout);

return () => {
cancelAnimationFrame(frame);
observer.disconnect();
};
}, []);

return (
<>
<List
id="percentage-gutter-list"
itemHeight={20}
height={100}
fullHeight={false}
data={data}
itemKey="id"
scrollWidth={1000}
style={{ width: 200, border: '1px solid red' }}
styles={{ horizontalScrollBar: { height: '50%' } }}
>
{({ id }) => (
<div data-regression-row style={{ height: 20 }}>
{id}
</div>
)}
</List>
<p role="status" data-testid="percentage-gutter-result">
{layoutResult}
</p>
</>
);
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
},
"dependencies": {
"@babel/runtime": "^8.0.0",
"@rc-component/resize-observer": "^1.0.1",
"@rc-component/resize-observer": "^1.1.0",
"@rc-component/util": "^1.4.0",
"clsx": "^2.1.1"
},
Expand Down
Loading
Loading