Repository navigation
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@r-barnes has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126709681. |
Summary: Pull Request resolved: #59520 Clang reports `-Wunreachable-code-break` here: the `break` follows `LOG(FATAL)`, which never returns, so control can never reach the `break`. Removing it silences the warning and does not change behavior. It ends the last label of the switch, so it is redundant anyway. Changelog: [Internal] Reviewed By: dtolnay Differential Revision: D126709681
meta-codesync
Bot
changed the title
meta-codesync
Bot
force-pushed
the
export-D126709681
branch
from
October 26, 2026 22:33
a13ac7a to
4a21e37
Compare
Collaborator
|
This pull request was successfully merged by @r-barnes in 4a21e37 When will my fix make it into a release? | How to file a pick request? |
Collaborator
|
This pull request was successfully merged by @r-barnes in 0c7d87f When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Clang reports
-Wunreachable-code-breakhere: thebreakfollowsLOG(FATAL), which never returns, so control can never reach thebreak. Removing it silences the warning and does not change behavior. It ends the last label of the switch, so it is redundant anyway.Changelog: [Internal]
Reviewed By: dtolnay
Differential Revision: D126709681