Repository navigation
fix: preserve indexed access type details - #1149
Open
blueDaydreaming725 wants to merge 1 commit into
Open
blueDaydreaming725 wants to merge 1 commit into
blueDaydreaming725 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 59704ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for react-docgen ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #906.
Props typed through indexed access, such as
Base['size'], currently retain the resolved type name but lose its details. This preserves union members and nested object signatures by copying the already resolved type instead of reconstructing only its name.The indexed expression remains the
rawvalue. The source property's top-levelrequiredflag is excluded, so it does not leak into the indexed type; nested property flags remain intact. Reusing the resolved descriptor also avoids a separate indexed-access parser.Validation
parse()covered union members, nested signatures and required flags; independent code review passed.Website and CLI package suites were not run.