Repository navigation
Keep the ref scrolling example scrollable across viewport sizes - #8706
Open
kinqsradio wants to merge 1 commit into
Open
kinqsradio wants to merge 1 commit into
kinqsradio wants to merge 1 commit into
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8299.
The ref-scrolling example stops demonstrating horizontal scrolling between 935px and 1023px viewport widths: its container grows wide enough to fit all three cat images, so every button leaves the horizontal scroll position at zero. At 1024px the sidebar appears, narrows the example, and makes scrolling visible again.
Cap the example's container at 400px and center it. It still shrinks on smaller screens, while retaining horizontal overflow on wider screens. The ref handlers and shared Sandpack styles are unchanged.
Validation:
yarn check-all,yarn ci-check, andgit diff --checkpass. The existing Next.js image-lint warnings remain.Browser verification used Chromium on the local Next.js development server, with the repository's standard remote Sandpack bundler and image URLs. Firefox and Safari were not tested.