[shin19991207]

Currently, only "move instance method" refactoring uses requestMoveWithConfirmation(). Other "move" refactoring actions send requests directly and pass their responses to applyRefactorEdit(), which displays messages as notifications instead of offering the Continue/Cancel confirmation dialog.

This PR routes all supported "move" refactoring actions through the existing confirmation helper.

Tested with eclipse-jdtls/eclipse.jdt.ls#3953

[datho7561]

I'm trying this out with the given test case and VS Code freezes then crashes.

[shin19991207]

@datho7561 Hmmm .... Not sure if it is related to microsoft/vscode#321312. Does configuring "window.dialogStyle": "custom" help solve the issue?

[datho7561]

That helped, but I think I see the root cause of the problem now:

[shin19991207]

I can reproduce the repeated warnings using the original test files plus this additional file:

src/test1/Noise.java

package test1;

// Missing is intentionally undefined
class Noise {
    int use(Missing receiver) {
        return receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value()
                + receiver.value() + receiver.value() + receiver.value() + receiver.value();
    }
}

However, this doesn't seem specific to VS Code or this patch (?) I also get repeated warnings when performing the same refactoring in Eclipse IDE with upstream JDT.

Do you see the same repeated messages when testing your project in Eclipse? (Not sure if my reproduction matches your case exactly because yours look endless)

I added .distinct() so repeated messages appear only once and this makes the VSCode dialog shorter. Does it resolve the issue on your setup?