Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
a133f08
rerun-sdk: Add versions 0.39.0, 0.40.0
riseproject-dev[bot] Oct 22, 2026
dcb529b
rerun-sdk: carry the lance-linalg riscv64 SIMD fallback patch to 0.39.0
luhenry Oct 23, 2026
97f0d02
rerun-sdk: carry the lance-linalg riscv64 SIMD fallback patch to 0.40.0
luhenry Oct 23, 2026
29dd44a
rerun-sdk: carry the lance-core riscv64 SIMD fallback patch to 0.39.0
luhenry Oct 23, 2026
def333f
rerun-sdk: carry the lance-core riscv64 SIMD fallback patch to 0.40.0
luhenry Oct 23, 2026
8420b31
rerun-sdk: carry the cargo [patch] wiring for lance crates to 0.39.0
luhenry Oct 23, 2026
e16e994
rerun-sdk: carry the cargo [patch] wiring for lance crates to 0.40.0
luhenry Oct 23, 2026
83909a2
rerun-sdk: keep the 0.39.0 cargo [patch] file byte-identical to 0.38.1
luhenry Oct 23, 2026
c4fb7b0
rerun-sdk: keep the 0.40.0 cargo [patch] file byte-identical to 0.38.1
luhenry Oct 23, 2026
d094112
rerun-sdk: ignore test files that need the unbuilt rerun-cli or av
luhenry Oct 27, 2026
6753874
rerun-sdk: deselect test_gop_batching (needs the datafusion package)
luhenry Oct 28, 2026
25a4745
rerun-sdk: Add versions 0.39.0, 0.40.0, 0.41.0
riseproject-dev[bot] Oct 29, 2026
fa4c3e8
rerun-sdk: copy the lance riscv64 patches to 0.41.0
luhenry Oct 30, 2026
f456212
rerun-sdk: copy the lance-linalg riscv64 patch to 0.41.0
luhenry Oct 30, 2026
a03e886
rerun-sdk: fix the i32 min call in the 0.41.0 lance-linalg patch
luhenry Oct 30, 2026
4fb3b1d
rerun-sdk: add a 0.41.0 patch for the new re_protos build script
luhenry Oct 31, 2026
d7833d2
build-rerun-sdk: apply the re_protos protoc fallback patch when a ver…
luhenry Oct 31, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/build-rerun-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,17 @@ jobs:

git apply python-wheels/patches/rerun-sdk/${{ env.RERUN_SDK_VERSION }}/0002-cargo-patch-lance-crates-for-riscv64.patch

# 0.41.0's re_protos/build.rs calls protoc_bin_vendored::protoc_bin_path()?,
# which has no riscv64 binary; the patch falls back to the system protoc
# installed below (PROTOC_INCLUDE points at its include dir). Earlier
# releases have no such patch.
- name: Patch re_protos to use the system protoc
run: |
patch_file="python-wheels/patches/rerun-sdk/${RERUN_SDK_VERSION}/0004-re_protos-fall-back-to-the-system-protoc-when-protoc-bin-vendored-has-no-binary.patch"
if [ -f "$patch_file" ]; then
git apply "$patch_file"
fi

# re_importer moved from crates/store/re_importer (0.37.x) to
# crates/data_flow/re_importer (0.38.0+) upstream; CIBW_TEST_SOURCES
# below needs its importer_mcap test-assets path to track whichever one
Expand Down Expand Up @@ -245,7 +256,10 @@ jobs:
# upstream-labelled sandboxes/integration suites, not the SDK's
# regression tests. test_headless_viewer.py spawns the (unbuilt)
# rerun-cli binary, same as test_rrd_reader_multi_store.py's
# session fixture (`rerun rrd merge`). test_server.py needs the
# session fixture (`rerun rrd merge`); test_rrd_route.py (0.39+)
# shells out to `rerun rrd route` the same way, and
# test_dataloader_video_conversion.py / test_dataloader_video_rgb_bank.py
# (0.40+) import av, like test_dataloader_video.py. test_server.py needs the
# `datafusion` Python package (no riscv64 wheel anywhere, same as
# test_datafusion_utils.py and, new in 0.38.x, test_chunk_index.py,
# which imports `from datafusion import col, lit` at module scope);
Expand Down Expand Up @@ -276,6 +290,8 @@ jobs:
# test_laziness, test_own_chunk_rules) don't touch `.reader()` and
# pass, so they're deselected individually rather than the whole
# file ignored.
# 0.40.0 adds test_gop_batching, which fails the same way (it reaches
# `ChunkStore.reader()`), so it is deselected too.
CIBW_TEST_COMMAND: >-
cd rerun_py &&
python -c "import rerun_bindings.rerun_bindings as m; assert m.__file__.endswith('.so'), m.__file__" &&
Expand All @@ -288,10 +304,13 @@ jobs:
--ignore=tests/integration/test_chunk_store_reader.py
--ignore=tests/integration/test_chunk_index.py
--ignore=tests/integration/test_rrd_reader_multi_store.py
--ignore=tests/integration/test_rrd_route.py
--ignore=tests/unit/test_dataloader_decoder_helpers.py
--ignore=tests/unit/test_dataloader_manifest.py
--ignore=tests/unit/test_dataloader_query_indices.py
--ignore=tests/unit/test_dataloader_skip_incomplete.py
--ignore=tests/unit/test_dataloader_video_conversion.py
--ignore=tests/unit/test_dataloader_video_rgb_bank.py
--ignore=tests/unit/test_sample_index.py
--ignore=tests/unit/test_datafusion_utils.py
--ignore=tests/unit/test_viewer_client.py
Expand All @@ -306,6 +325,7 @@ jobs:
--deselect=tests/integration/test_optimized_stream.py::test_chunk_store_path
--deselect=tests/integration/test_optimized_stream.py::test_sweep_order_observable
--deselect=tests/integration/test_optimized_stream.py::test_own_chunk_default
--deselect=tests/integration/test_optimized_stream.py::test_gop_batching

- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
with:
Expand Down
3 changes: 3 additions & 0 deletions docs/packages/rerun-sdk.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,6 @@ versions:
- filename: rerun_sdk-0.38.1-cp310-abi3-manylinux_2_39_riscv64.whl
sha256: 0c0189df56778c3a6256500d6c49f33f83c43e1783119e39932f29c2fafbc96e
requires-python: '>=3.10'
- version: 0.39.0
- version: 0.40.0
- version: 0.41.0
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
Upstream-Status: To upstream [lance's own SIMD-tier cfg arms have no catch-all for architectures without a dedicated tier (riscv64 included); not filed upstream per this session's policy against opening external issues/PRs]

--- a/src/utils/cpu.rs
+++ b/src/utils/cpu.rs
@@ -210,6 +210,17 @@
SimdSupport::None
}
}
+ // riscv64 (and any other architecture without a dedicated tier above) has
+ // no SIMD kernels in lance yet; upstream's cfg arms have no catch-all, so
+ // this closure otherwise evaluates to `()` here instead of `SimdSupport`.
+ #[cfg(not(any(
+ target_arch = "aarch64",
+ target_arch = "x86_64",
+ target_arch = "loongarch64"
+ )))]
+ {
+ SimdSupport::None
+ }
});

#[cfg(target_arch = "x86_64")]
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
Upstream-Status: Inappropriate [points at a directory this port's workflow materializes at runtime; not a fix rerun itself would carry]

diff --git a/Cargo.lock b/Cargo.lock
index f4ad0ef..620282b 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -5693,8 +5693,6 @@ dependencies = [
[[package]]
name = "lance-core"
version = "10.0.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "21f4fd872bfe948150a6878d983327c4f150dc1b629e94ae7677310fa6a3f35f"
dependencies = [
"arrow-array",
"arrow-buffer",
@@ -5992,8 +5990,6 @@ dependencies = [
[[package]]
name = "lance-linalg"
version = "10.0.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5a1dd49fdf61da86650dc335fbe1f239803f9d73bc2bc5ffbc0c905dd8809892"
dependencies = [
"arrow-array",
"arrow-buffer",
diff --git a/Cargo.toml b/Cargo.toml
index 3717ef5..bf40033 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -868,6 +868,8 @@ self_named_module_files = "allow" # Disabled waiting on https://github.com/rust-
significant_drop_tightening = "allow" # An update of parking_lot made this trigger in a lot of places. TODO(emilk): fix those places

[patch.crates-io]
+lance-core = { path = "lance-core-10.0.0-riscv64" }
+lance-linalg = { path = "lance-linalg-10.0.0-riscv64" }
# Try to avoid patching crates! It prevents us from publishing the crates on crates.io.
# If you do patch always prefer to patch to the trunk branch of the upstream repo (i.e. `main`, `master`, …).
# If that is not possible, patch to a branch that has a PR open on the upstream repo.
Loading
Loading