Skip to content

fix(acme): apply issuer settings and restore certificate renewal - #307

Merged
rustatian merged 1 commit into
masterfrom
fix/acme-issuer-config
Oct 28, 2026
Merged

rustatian merged 1 commit into
masterfrom
fix/acme-issuer-config

Conversation

@rustatian

Copy link
Copy Markdown
Member

Reason for This PR

closes: roadrunner-server/roadrunner#2455

Description of Changes

  • Use the configured ACME issuer for the CA, email, challenge type, and alternate ports.
  • Use the same certificate configuration for issuance and renewal. Stop cache maintenance if certificate setup fails.
  • Add regression tests for issuer settings and certificate cache updates.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 19:29

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the changes aligning ACME issuance and renewal with the configured issuer settings.

No open issues 🎉

What changed in this PR

This PR fixes ACME certificate handling so issuance and renewal use the configured issuer settings consistently.

Changes:

  • Replace the default issuer list with the configured ACME issuer.
  • Reuse the certificate configuration for cache maintenance and stop maintenance if certificate setup fails.
  • Add regression tests for issuer settings and reloading renewed certificates from storage.
File Description
CHANGELOG.md Document the ACME issuer and renewal fixes.
acme/​acme.go Share configuration between issuance and renewal, apply issuer settings, and clean up on failure.
acme/​acme_test.go Test issuer settings and renewed certificate cache updates.

Review effort: Balanced

@rustatian rustatian self-assigned this Oct 28, 2026
@rustatian
rustatian merged commit ca3fbb3 into master Oct 28, 2026
7 checks passed
@codecov

codecov Bot commented Oct 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (384111e) to head (779fcd5).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
acme/acme.go 31.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   88.47%   90.05%   +1.58%     
==========================================
  Files          29       29              
  Lines        1345     1348       +3     
==========================================
+ Hits         1190     1214      +24     
+ Misses        155      134      -21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rustatian
rustatian deleted the fix/acme-issuer-config branch October 28, 2026 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: ACME ignores email, use_production_endpoint and challenge settings: certificates come from certmagic's default issuer

2 participants