Skip to content

[DO NOT MERGE][ABI test] rolling / compatible, then ABI break, then revert: labels flip and come back - #3384

Closed
fujitatomoya wants to merge 3 commits into
rollingfrom
abi-test/rolling-compatible-then-break
Closed

fujitatomoya wants to merge 3 commits into
rollingfrom
abi-test/rolling-compatible-then-break

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Case: target rolling. Three steps on one pull request: a compatible commit, then a commit that breaks ABI, then a revert of that break. The labels must follow the latest verdict, and labels removed by the bot (not by a person) must come back.


This is a test pull request for the ABI checker (abi.yaml / abi-report.yaml, backed by
fujitatomoya/ros2-abi-action) and the
backport-<distro> candidate labels (#2555). It exists only for fujitatomoya to verify the
action result for one specific case, and it is closed without merging once that is done.
Maintainers: nothing to review here, please ignore this pull request.

🤖 Generated with Claude Code

…reak, revert case)

ABI checker / backport label test; this pull request is closed without merging.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
@fujitatomoya

fujitatomoya commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator Author

Expected result

Step 1 (comment-only commit, compatible)

  • abi check: success, label ABI compatible
  • backport labels added: backport-lyrical, backport-kilted, backport-jazzy, backport-humble

Step 2 (push a commit that changes the expand_topic_or_service_name() signature)

  • abi check: success (advisory on rolling), sticky comment updated to Verdict: incompatible
  • ABI compatible removed, ABI break added
  • all four backport-* labels removed by github-actions[bot]

Step 3 (push a revert of step 2)

  • abi check: success, sticky comment back to Verdict: compatible
  • ABI break removed, ABI compatible added
  • all four backport-* labels added again (the step 2 removals were by the bot, so they do not count as removed by hand)

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ compatible No ABI changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ 1262075
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ 1262075
(empty report — no differences printed by abidiff)
✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ 1262075
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ 1262075
(empty report — no differences printed by abidiff)

Updated for commit 1262075 · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed expected result, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant