Skip to content

Backport the ABI compatibility check workflow to lyrical - #3392

Open
fujitatomoya wants to merge 1 commit into
lyricalfrom
fujitatomoya/lyrical/abi-check
Open

fujitatomoya wants to merge 1 commit into
lyricalfrom
fujitatomoya/lyrical/abi-check

Conversation

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Verbatim copy of .github/workflows/abi.yaml from rolling (#3262, #3276, #3340, #3341). Without it, pull requests targeting lyrical get neither the ABI check nor the "ABI compatible" / "ABI break" and backport- labels, because pull_request workflows run from the workflow file of the target branch.

Only abi.yaml is needed here: the sticky comment and the labels are published by abi-report.yaml, a workflow_run workflow, which GitHub always runs from the default branch (rolling). The distro and the REP-0009 policy are resolved from the target branch (distro: auto, policy: auto), so the check is strict on lyrical: an incompatible ABI change fails the check.

Verified with the same file on test pull request(s) #3385 (compatible) and #3386 (ABI break).

Description

backport of abi compliance check github action.

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes, Claude Fable 5.1

Additional Information

Verbatim copy of .github/workflows/abi.yaml from rolling (#3262, #3276,
ABI check nor the "ABI compatible" / "ABI break" and backport-<distro>
labels, because pull_request workflows run from the workflow file of the
target branch.

Only abi.yaml is needed here: the sticky comment and the labels are
published by abi-report.yaml, a workflow_run workflow, which GitHub always
runs from the default branch (rolling). The distro and the REP-0009 policy
are resolved from the target branch (distro: auto, policy: auto), so the
check is strict on lyrical: an incompatible ABI change fails the check.

Verified with the same file on test pull request(s) #3385 (compatible) and #3386 (ABI break).

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: Tomoya.Fujita <[email protected]>
@fujitatomoya
fujitatomoya force-pushed the fujitatomoya/lyrical/abi-check branch from 8c2b118 to 1ad573e Compare October 28, 2026 00:56
@fujitatomoya fujitatomoya self-assigned this Oct 28, 2026

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde can you review this and merge?

after these PRs, we can say that abi compliance checker actions are supported officially for all distribution under rclcpp. and i will integrate this action for other c/c++ projects.

@github-actions

Copy link
Copy Markdown

ABI Compliance Check

✅ Verdict: compatible

Library Verdict Summary
libcomponent_manager.so ✅ compatible No ABI changes detected.
librclcpp.so ✅ compatible No ABI changes detected.
librclcpp_action.so ✅ compatible No ABI changes detected.
librclcpp_lifecycle.so ✅ compatible No ABI changes detected.
✅ libcomponent_manager.so — full abidiff report

Compared:

  • Base: lib-base/libcomponent_manager.so
  • Head: lib-pr/libcomponent_manager.so @ 1ad573e
(empty report — no differences printed by abidiff)
✅ librclcpp.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp.so
  • Head: lib-pr/librclcpp.so @ 1ad573e
(empty report — no differences printed by abidiff)
✅ librclcpp_action.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_action.so
  • Head: lib-pr/librclcpp_action.so @ 1ad573e
(empty report — no differences printed by abidiff)
✅ librclcpp_lifecycle.so — full abidiff report

Compared:

  • Base: lib-base/librclcpp_lifecycle.so
  • Head: lib-pr/librclcpp_lifecycle.so @ 1ad573e
(empty report — no differences printed by abidiff)

Updated for commit 1ad573e · check run · suppressions: /home/runner/work/_temp/ros2-abi-suppressions.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant