Repository navigation
Backport the ABI compatibility check workflow to lyrical - #3392
Open
fujitatomoya wants to merge 1 commit into
Open
fujitatomoya wants to merge 1 commit into
fujitatomoya wants to merge 1 commit into
Conversation
Verbatim copy of .github/workflows/abi.yaml from rolling (#3262, #3276, ABI check nor the "ABI compatible" / "ABI break" and backport-<distro> labels, because pull_request workflows run from the workflow file of the target branch. Only abi.yaml is needed here: the sticky comment and the labels are published by abi-report.yaml, a workflow_run workflow, which GitHub always runs from the default branch (rolling). The distro and the REP-0009 policy are resolved from the target branch (distro: auto, policy: auto), so the check is strict on lyrical: an incompatible ABI change fails the check. Verified with the same file on test pull request(s) #3385 (compatible) and #3386 (ABI break). Co-Authored-By: Claude Fable 5.1 <[email protected]> Signed-off-by: Tomoya.Fujita <[email protected]>
fujitatomoya
force-pushed
the
fujitatomoya/lyrical/abi-check
branch
from
October 28, 2026 00:56
8c2b118 to
1ad573e
Compare
fujitatomoya
commented
Oct 28, 2026
fujitatomoya
left a comment
Collaborator
Author
There was a problem hiding this comment.
@ahcorde can you review this and merge?
after these PRs, we can say that abi compliance checker actions are supported officially for all distribution under rclcpp. and i will integrate this action for other c/c++ projects.
ABI Compliance Check✅ Verdict: compatible
✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verbatim copy of .github/workflows/abi.yaml from rolling (#3262, #3276, #3340, #3341). Without it, pull requests targeting lyrical get neither the ABI check nor the "ABI compatible" / "ABI break" and backport- labels, because pull_request workflows run from the workflow file of the target branch.
Only abi.yaml is needed here: the sticky comment and the labels are published by abi-report.yaml, a workflow_run workflow, which GitHub always runs from the default branch (rolling). The distro and the REP-0009 policy are resolved from the target branch (distro: auto, policy: auto), so the check is strict on lyrical: an incompatible ABI change fails the check.
Verified with the same file on test pull request(s) #3385 (compatible) and #3386 (ABI break).
Description
backport of abi compliance check github action.
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes, Claude Fable 5.1
Additional Information