Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo deny check advisoriesfails onmainwith 17 advisories published since the last CI run (rustls, rustls-webpki, webpki-roots, quinn-proto, zip, crypto-bigint). Every PR and release pipeline will fail on it.The Clippy job is also red on
main: current stable Clippy reportsclippy::double_must_useon code generated byasync-trait 0.1.89.Root cause
Cargo.lockpins versions released before these advisories.zipis constrained to8.6, and the fixes for RUSTSEC-2026-0367/0368/0369 only exist in 9.x.crypto-bigint 0.5(RUSTSEC-2026-0387) comes from thesigv4afeature ofaws-sigv4, which has no release on the fixed 0.7.x line yet.Solution
Lockfile refresh
cargo updatewithin the existing semver ranges, no manifest change:rustls0.23.45 -> 0.23.46 (RUSTSEC-2026-0346/0347/0348/0349)rustls-webpki0.103.15 -> 0.103.16 (RUSTSEC-2026-0382)webpki-roots1.0.8 -> 1.0.11 (RUSTSEC-2026-0381)quinn-proto0.11.16 -> 0.11.19 (RUSTSEC-2026-0338/0339/0340/0341/0342)tokio1.52.3 -> 1.54.1,ctutils0.4.2 -> 0.4.5,chacha200.10.1 -> 0.10.2 (unsound/yanked warnings)async-trait0.1.89 -> 0.1.92, which fixes the Clippy failurezip 8.6 -> 9.1
Fixes RUSTSEC-2026-0367/0368/0369. rc does not call
extract(), which these advisories target, but the check fails on them regardless.ZipFile::name()now returns aResultsince names are decoded on demand. The IAM and bucket-metadata importers map a decoding failure to their existing "unreadable entry" error. zip 9.1 requires Rust 1.88, within the 1.92 MSRV.Ignore RUSTSEC-2026-0387 (crypto-bigint)
Documented ignore in
deny.toml, next to the existing RSA entry. rc aliases only sign with SigV4, and SigV4a is only used for Multi-Region Access Point ARNs. To be removed onceaws-sigv4depends oncrypto-bigint >= 0.7.6.Alternative: dropping the
sigv4afeature fromaws-sdk-s3would remove the dependency entirely, at the cost of MRAP support.Validation
cargo fmt --all --check- passcargo clippy --workspace --all-targets --locked -- -D warnings- pass, zero warningscargo test --workspace- pass, 2686 passed, 0 failedcargo test -p rustfs-cli --features golden --test golden- passRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps- passcargo build --workspacewith Rust 1.92 (MSRV, Linux) - passcargo deny check advisories- pass