Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ScipWritercreates its temporary output file with thePosixFilePermissionsattributerw-r--r--:On file systems that do not support POSIX permissions, such as NTFS on Windows, this throws:
scip-java aggregatetherefore exits before it writesindex.scip. This affects anything that runs the aggregator on Windows, including runningScipJava aggregatefrom a Maven build.ScipWriteris the only class inscip-aggregator,scip-java,scip-javacandscip-sharedthat uses POSIX file permissions.Fix
Create the temp file with the
rw-r--r--attribute only when the default file system reports theposixattribute view. Otherwise create it with the default permissions. Behavior on POSIX file systems is unchanged.Testing
Added
ScipWriterTest, which creates aScipWriter, builds an empty index into a temp directory, and asserts the output file exists. It does not simulate a non-POSIX file system, so it exercises the fix only on Windows runners.gradle :scip-aggregator:testandgradle spotlessCheckpass.