Repository navigation
fix(plugin-braze): expand @braze/react-native-sdk peer range to support v20+ - #1344
Open
sunitaprajapati89 wants to merge 3 commits into
Open
sunitaprajapati89 wants to merge 3 commits into
sunitaprajapati89 wants to merge 3 commits into
Conversation
Bounds the peer range and updates yarn.lock to match. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
didiergarcia
approved these changes
Oct 26, 2026
MichaelGHSeg
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expands the
@braze/react-native-sdkpeer dependency in@segment/analytics-react-native-plugin-brazefrom^16.xto>=16.0.0 <24.0.0, and updatesyarn.lockto match.Supersedes #1340 by @danish-pg. That PR comes from a fork, so its CI jobs fail at the Artifactory OIDC step (
ARTIFACTORY_URL is empty). The original commits are kept here so authorship is preserved.Motivation
Apps on React Native 0.76+ / Expo 52+ use
@braze/react-native-sdkv20.x, and strict package managers such as pnpm report an unmet peer dependency against^16.x.Changes on top of #1340
<24.0.0instead of open-ended>=16.0.0, so future majors are not silently accepted.yarn.lockis updated. Without ityarn install --immutablefails with YN0028 because Yarn records workspace peer dependencies in the lockfile.Compatibility
I compared the type definitions of every Braze method
BrazePlugincalls (changeUser,setDateOfBirth,setGender,logCustomEvent,logPurchase,setAttributionData,setCustomUserAttribute,requestImmediateDataFlush,GenderTypes,MonthsAsNumber) across v16.1.0, v20.1.0, v21.1.0, v22.0.0 and v23.1.0. They are unchanged apart from some parameters becoming nullable. Plugin tests still run against the^16.xdev dependency only. The v21 to v23 releases include native SDK bumps (for example Xcode 26 in v21), which affect consumers' native builds but not the plugin's JS.Checklist