Skip to content

fix(tests): derive document grant expiry from one timestamp - #9325

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-document-delegation-fixture-20261022
Oct 23, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/fix-document-delegation-fixture-20261022

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Derive the document integration fixture’s expiry from its issued-at timestamp. Separate clock reads could produce a grant just over the maximum lifetime and intermittently fail authorization before the document assertion ran.
  • Preserve the production TTL limit and all document security and persistence assertions.

Type of Change

  • Bug fix

Testing

  • All 29 resource-delegation authorization tests and root lint passed.
  • Hosted clock-boundary validation: the old two-clock expiry fails with the intended authorization error; all eight document checks pass three times per provisioning path with the fix.
  • PR CI passed, including all 16 integration shards. Both automated reviews are 5/5 with no unresolved threads.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (test-audit reviewed; hosted integration verified)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 23, 2026 12:16am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Updates the document integration fixture to derive expiresAt from one issuedAt timestamp.

  • Document integration grants now use one timestamp for expiry.

Reviews (1) · Last reviewed commit: "fix(tests): derive document grant expiry..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 9a66fee into staging Oct 23, 2026
45 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/fix-document-delegation-fixture-20261022 branch October 23, 2026 00:18

This branch was previously deployed

1 inactive deployment
Preview — 58179111 Deployed Oct 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant