Repository navigation
fix(audit): cap rollup writes process-wide and name the run on credential access entries - #9407
Conversation
…tial access entries
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge, with no new blocking findings. SummaryThis PR caps rollup inserts at ten across the process and adds workflow and execution IDs to credential-access entries.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
ROLLUP_WRITE_CONCURRENCYcaps every insert in flight. Before, each window timer, size flush, and scope end started its own batch, so a burst of distinct rollups could insert all at oncecredential.accessedentries from a workflow run now recordmetadata.workflowIdandmetadata.executionId(tool calls and Vertex AI credentials in Agent, Router, and Evaluator), so a merged entry says which run used the credentialType of Change
Testing
lib/oauth/token-resolution, selector, personal-token, andexecutor/utilstests (369) and the@sim/auditsuite passChecklist
test-auditauthoring gate)