fix(search): harden assistant review and account discovery by waleedlatif1 · Pull Request #9478 · simstudioai/sim

waleedlatif1 · 2026-10-30T17:46:19Z

Summary

Clarify Assistant approval cards, display readable field values and receipt states, remove redundant permission resets and row dividers, and place the New search icon before its label.
Use shared resource-header actions with a red Disconnect label, permission-group info badges for tool descriptions, and refreshed Search/approval screenshots.
Keep admin visibility checks on the active transaction and omit unavailable accounts from action discovery while retaining their connection details.
Preserve provider-account identity across reconnects, align enrollment status with actual scopes, and coalesce verified Salesforce destination lookups without caching credentials.
Address the Search/Assistant findings in v0.9.37: search split, deps bumps, db improvements, unified integration permissions, sim links, new docs #9474 and retain successful browser screenshots for UI review.

Organization connections remain limited to one account per provider. Multi-account browser fixtures exercise defensive account isolation; they do not imply that users can provision a second account.

Type of Change

Bug fix

Testing

CI passed on the final commit: real database/Redis regressions, browser interaction suites, production build, type checks, lint, and repository audits. The Search/Assistant acceptance reports contain 55 passing HTTP/browser checks and 71 preview captures, including tool-description hover and keyboard access. Further local test execution was intentionally deferred to CI.
Before that handoff, the production build and 69 Assistant integration checks passed. Six identity-change cases failed on the original implementation; removing each identity guard independently reproduced its three corresponding failures.
Added coverage for transaction-local visibility, disabled account discovery, scope reporting, destination lookup failure/retry, token rotation, fresh authorization, and email preview/receipt behavior.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-10-30T17:46:21Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 30, 2026 7:26pm UTC

greptile-apps · 2026-10-30T17:49:51Z

Confidence Score: 5/5

[High impact] No established issue blocks merging this revision.

Summary

This PR improves Assistant review cards, account discovery, reconnect checks, and Salesforce destination lookups.

Managed connections stay tied to the provider account that first connected.
Admin-gated Assistant tools reflect the active database transaction.
Search action discovery lists only accounts with an available action.
Assistant approval cards and receipts show clearer account and action details.
Managed Salesforce calls reuse recently verified account destinations.
Integration controls and Search actions use clearer labels and placement.
Build checks retain browser screenshots and stop exporting an unused flag.

_{Reviews (9) · Last reviewed commit: "docs(search): refresh tool permissions w..." · Reviewed by Greptile}

cubic-dev-ai

All reported issues were addressed across 19 files

_{This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T18:00:42Z

@greptile

waleedlatif1 · 2026-10-30T18:00:44Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T18:00:52Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 19 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T18:11:18Z

@greptile

waleedlatif1 · 2026-10-30T18:11:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T18:11:26Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

waleedlatif1 · 2026-10-30T18:13:54Z

@greptile

cubic-dev-ai

No issues found across 20 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T18:13:56Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T18:14:03Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 20 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T18:16:15Z

@greptile

waleedlatif1 · 2026-10-30T18:16:17Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T18:16:24Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 20 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T18:36:46Z

@greptile

waleedlatif1 · 2026-10-30T18:36:47Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T18:36:53Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 24 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T18:53:14Z

@greptile

waleedlatif1 · 2026-10-30T18:53:15Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T18:53:23Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 27 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T19:08:24Z

@greptile

waleedlatif1 · 2026-10-30T19:08:25Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T19:08:31Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 27 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-10-30T19:19:44Z

@greptile

waleedlatif1 · 2026-10-30T19:19:45Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-30T19:19:51Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 27 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic}

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

Comment thread apps/sim/lib/credential-groups/oauth.ts Resolved

Comment thread apps/sim/app/o/[organizationId]/integrations/accounts/[credentialId]/tool-permissions.tsx Resolved

Comment thread apps/sim/components/assistant-actions/action-receipt.tsx Resolved

vercel Bot deployed to Preview October 30, 2026 17:53

View deployment

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

vercel Bot deployed to Preview October 30, 2026 18:06

View deployment

vercel Bot temporarily deployed to Preview October 30, 2026 18:11 Inactive

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

waleedlatif1 force-pushed the codex/search-review-followups branch from 227f0dc to 911f884 Compare October 30, 2026 18:13

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview October 30, 2026 18:16 Inactive

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

waleedlatif1 mentioned this pull request Oct 30, 2026

v0.9.37: search split, deps bumps, db improvements, unified integration permissions, sim links, new docs #9474

Merged

waleedlatif1 added 5 commits October 30, 2026 11:35

fix(search): harden assistant review and account discovery

ee10715

fix(search): clarify reconnect recovery and receipt states

7aac445

fix(search): tighten review spacing and capture full UI states

f60332e

test(search): scope filter assertion to the result link

a2b3d4d

fix(search): align account actions and simplify tool rows

ca659d2

waleedlatif1 force-pushed the codex/search-review-followups branch from 3b0ed92 to ca659d2 Compare October 30, 2026 18:36

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

Comment thread scripts/check-unused-exports.baseline.json Resolved

vercel Bot deployed to Preview October 30, 2026 18:43

View deployment

chore(search): refresh permissions docs and verify receipt captures

40f14f9

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

vercel Bot deployed to Preview October 30, 2026 18:59

View deployment

fix(search): match tool descriptions to permission group info badges

8cb507c

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

vercel Bot deployed to Preview October 30, 2026 19:17

View deployment

docs(search): refresh tool permissions with description badges

d1ed21a

cubic-dev-ai Bot reviewed Oct 30, 2026

View reviewed changes

vercel Bot deployed to Preview October 30, 2026 19:26

View deployment

waleedlatif1 merged commit 3175daa into staging Oct 30, 2026
70 checks passed

waleedlatif1 deleted the codex/search-review-followups branch October 31, 2026 00:05

Conversation

waleedlatif1 commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 30, 2026

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

waleedlatif1 commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 30, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Oct 30, 2026

waleedlatif1 commented Oct 30, 2026 •

edited

Loading

vercel Bot commented Oct 30, 2026 •

edited

Loading

greptile-apps Bot commented Oct 30, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading