Repository navigation
Handle revoked installations in status checks - #185
Merged
Merged
Conversation
dblock
force-pushed
the
fix/inactive-status
branch
from
October 25, 2026 19:53
33f6670 to
a08bab3
Compare
dblock
force-pushed
the
fix/inactive-status
branch
from
October 25, 2026 19:56
a08bab3 to
d64fe4a
Compare
Co-authored-by: Copilot <[email protected]>
dblock
force-pushed
the
fix/inactive-status
branch
from
October 25, 2026 19:59
d64fe4a to
6887a71
Compare
Danger ReportNo issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address the status-endpoint portion of #152. Select an active installation rather than pinging inactive credentials. When Slack returns
account_inactiveorinvalid_auth, log the failure, deactivate through the existing service callbacks, and return HTTP 200 with an explicitping: { ok: false, error: ... }. Compute the active-team count after the ping so it reflects deactivation. When no active installations remain, skip the Slack call. Other failures retain their error behavior and do not deactivate installations.Document the changed monitoring contract in UPGRADING. This does not change general OAuth reinstall semantics or implement RTM socket teardown/restart; that part of #152 needs follow-up in the extracted RTM extension. The issue deliberately remains open.
Validation
Status and existing OAuth/reinstall specs pass with Mongoid 9.1 and Active Record 8.1 on Ruby 4.0.9 / Grape 4: 37 examples, 0 failures each. Lint passes. Cases cover selection among inactive records, both terminal credential errors, updated counts, service deactivation, unrelated errors, and no-active-team behavior.
Authored by Copilot (AI), on behalf of @dblock.