Repository navigation
Skip fork and missing-command tests where they cannot run - #480
Open
sampokuokkanen wants to merge 1 commit into
Open
sampokuokkanen wants to merge 1 commit into
sampokuokkanen wants to merge 1 commit into
Conversation
The fork tests now skip unless `Process.respond_to?(:fork)`, which is
false on JRuby and Windows. On JRuby the fork call raised
NotImplementedError, a ScriptError, which ended the whole sus run.
JRuby does not spawn a process for a missing command, so
`system("does-not-exist")` never reaches `process_wait`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork tests now skip unless
Process.respond_to?(:fork), which is false on JRuby and Windows. On JRuby the fork call raised NotImplementedError, a ScriptError, which ended the whole sus run.JRuby does not spawn a process for a missing command, so
system("does-not-exist")never reachesprocess_wait.Types of Changes
Contribution