Repository navigation
fix(preload): resolve anchor hrefs against document.baseURI - #706
Merged
Merged
Conversation
An anchor cloned from a <template> keeps its raw href until it is adopted into the page, so eagerPreload's idle flush threw Invalid URL on one a transition still held off the page. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_0117BoWNQHxQ9311k7tQMEKs
🦋 Changeset detectedLatest commit: 7488be9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #704.
Problem
anchorUrlbuilt HTML anchors' URLs withnew URL(a.href)and no base. Solid clones compiled nodes from a<template>. Until a clone is adopted into the page, itshrefproperty is the raw attribute (/about). WheneagerPreload's idle flush reached such an anchor, for example one a transition was still holding off the page, it threw an uncaughtInvalid URL.Change
anchorUrlnow resolves every anchor againstdocument.baseURI, the same way it already handled SVG anchors. An anchor already in the page has an absolutehref, so the base changes nothing for it. A clone resolves to the URL it will have once it is adopted, so it preloads correctly. Dropping the HTML/SVG branch makes the client bundle slightly smaller.Tests
test/data/events.spec.ts: an anchor cloned from a template is claimed undereagerPreload({ all: true })and flushed before it is adopted. Without the fix it fails withTypeError: Invalid URL; with the fix it preloads/a.pnpm testpasses (724 client, 102 server), as dopnpm test:typesand prettier.Generated by Claude Code