[sarankumar1325]

Fixes #694 (1.x side)

This is the main (1.x) counterpart of #695 and #707, which fixed the same bug on next.

Problem

saveCurrentDepth() in src/lifecycle.ts stamps an unstamped entry with _depth: history.length - 1, and set() in Router / HashRouter pushed the caller's state without a depth, so every router push got stamped that way. Browsers cap session history (50 entries in Chromium and Firefox). Once the cap is reached, pushState drops the oldest entry and history.length stays the same, so each new entry got the same _depth as the one below it. Back then computed delta = 0, which skipped useBeforeLeave, and scroll restoration put consecutive entries in the same slot.

Change

• src/lifecycle.ts:
  • New nextDepth(state): stamps a pushed entry with the current entry's depth + 1. It falls back to history.length - 1 only when no depth is known.
  • saveCurrentDepth(): an entry the router didn't push (e.g. a #anchor jump) is now stamped one above the last known depth instead of from history.length, as fix(history): stamp history depth from the current entry, not history.length #707 does on next.
• src/routers/Router.ts and src/routers/HashRouter.ts: push with nextDepth(state). Replace still uses keepDepth, and user state is kept.
• test/history-depth.spec.tsx: four tests.
  • Router and HashRouter, with history.length mocked at the 50-entry cap: push three times, then replace once. They expect depths [49, 50, 51, 51]. Without the change they get [49, 49, 49, 49].
  • User state is kept next to the stamp.
  • An entry pushed outside the router is stamped one above the last depth.
• A patch changeset.

All four tests fail without the src change.

Testing

• pnpm test (vitest + test:types): 17 files, 263 tests passed
• pnpm build

AI disclosure: I used an AI assistant to help write this change and its tests. I reviewed the diff and ran the checks above.

[changeset-bot]

🦋 Changeset detected

Latest commit: bf196cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@solidjs/router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR