Repository navigation
fix(bigquery): support escaped quotes in raw and bytes strings - #1002
Closed
MaxFreedomPollard wants to merge 1 commit into
Closed
MaxFreedomPollard wants to merge 1 commit into
MaxFreedomPollard wants to merge 1 commit into
Conversation
Fixes sql-formatter-org#762 Co-Authored-By: Claude Opus 5.5 <[email protected]>
Collaborator
|
I'm adopting a new policy for this repository: no AI-generated contributions. I don't care how good they are. This is to preserve my sanity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #762. BigQuery doesn't end an
r'...'orb'...'string at a backslash-escaped quote (GoogleSQL lexer), but the dialect lexed them with-raw, sor'a\'b'threw a parse error. They now use-bslike plain strings, and BigQuery's sharedR''test cases are replaced with an escaped-quote test, since those cases expectr'some \'to parse and BigQuery rejects that. I ran the tests with a small jest shim because I couldn't install dependencies, so lint, prettier and tsc weren't run.🤖 Generated with Claude Code