Repository navigation
Conversation
Collaborator
|
I assume this is AI generated. It's no good. I don't want to spend time explaining why, as you probably didn't spend much time in implementing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892.
DuckDB and T-SQL treat a window frame as part of the preceding
ORDER BYexpression and break its bounds atAND.Classify
ROWS BETWEENandRANGE BETWEENas frame clauses in these dialects, plusGROUPS BETWEENin DuckDB. Keep the bounds'ANDinline; ordinary booleanANDformatting is unchanged.Regressions cover frame types, idempotence and tabular indentation. Both reported-layout tests failed before the fix.
Validation on the published head: 27 Jest suites passed (5,892 tests passed, 1 skipped, 63 snapshots); repository-wide formatting, lint, type checking and CJS/ESM/webpack builds passed.
Local tools were installed separately on Windows/Node 24 without lockfile changes; CI uses Node 22. Other dialects retain their current frame layout. Classification remains lexical, consistent with these dialects' existing clause handling.