Repository navigation
Conversation
c3e3121 to
3be4832
Compare
3be4832 to
7cb677e
Compare
|
|
||
| /// The desired state of one condition, without the bookkeeping fields. | ||
| #[derive(Clone, Debug, Eq, PartialEq)] | ||
| pub struct ManagedCondition { |
There was a problem hiding this comment.
We have proper ClusterConditions https://github.com/stackabletech/operator-rs/blob/main/crates/stackable-operator/src/status/condition/mod.rs#L90 that might be reused or made generic to add custom condition type / etc.?
There was a problem hiding this comment.
I believe this definitely makes sense and I considered using the utility around ClusterCondition but it would require a larger refactor which I didn't want to do in this PR.
586debd to
22536cd
Compare
| Retain, | ||
|
|
||
| /// Delete the resource in the product. | ||
| Delete, |
There was a problem hiding this comment.
Question regarding a specific scenario: I guess it would be possible for someone to create a KafkaTopic object with a Kafka topic they theoretically shouldn't have permissions for and then just delete that object, in turn deleting that Kafka topic in the cluster. Would that be covered with authorization somehow? That scenario would be relevant for different user groups managing different topics in the same cluster but I think Kafka has also some system topics?
|
Claude noted down some possible lifecycle problems/decisions:
Not sure if this is part of this PR or not, but it seemed general enough to mention it in the operator-rs changes, if this provides some mechanism for all the operators. |
Description
Adds shared utilities required for stackabletech/kafka-operator#1028.
Depends on https://github.com/stackabletech/decisions/issues/98 and https://github.com/stackabletech/decisions/issues/99.
Definition of Done Checklist
Author
Reviewer
Acceptance