Skip to content

fix(cli): support fee-bump transactions in tx hash (#2769) - #2816

Closed
jdjioe5-cpu wants to merge 1 commit into
stellar:mainfrom
jdjioe5-cpu:fix/issue-2769-tx-hash-fee-bump
Closed

jdjioe5-cpu wants to merge 1 commit into
stellar:mainfrom
jdjioe5-cpu:fix/issue-2769-tx-hash-fee-bump

Conversation

@jdjioe5-cpu

Copy link
Copy Markdown

Summary

Fixes #2769

\stellar tx hash\ previously called \super::xdr::unwrap_envelope_v1\ on the input envelope, which caused fee-bump transaction envelopes (\TransactionEnvelope::TxFeeBump) to fail with \�rror: only transaction v1 is supported.

However, \crate::utils::transaction_env_hash\ already natively handles both \TransactionEnvelope::Tx\ and \TransactionEnvelope::TxFeeBump\ (via \ ee_bump_transaction_hash).

Changes

  • In \commands/tx/hash.rs, calculate hash using \ ransaction_env_hash(&tx_env, ...)\ instead of requiring v1 unwrap.
  • Added unit test in \commands/tx/hash.rs\ verifying fee-bump hash generation.
  • Added CLI regression test \ x_hash_supports_fee_bump_transaction\ in \cmd/crates/soroban-test/tests/it/tx.rs.

Verification

  • \cargo test -p soroban-cli --lib commands::tx::hash\ passed.
  • \cargo test -p soroban-test --test it tx\ passed.
  • \cargo clippy -p soroban-cli --lib -- -D warnings\ passed.
  • \cargo fmt --check\ passed.

@github-project-automation github-project-automation Bot moved this to Backlog (Not Ready) in DevX Oct 22, 2026
@github-project-automation github-project-automation Bot moved this from Backlog (Not Ready) to Done in DevX Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

tx hash fails on fee-bump transactions

2 participants