Repository navigation
fix(result): avoid mutating errors when pickling task results - #715
Open
wsjwu58-cmd wants to merge 1 commit into
Open
wsjwu58-cmd wants to merge 1 commit into
wsjwu58-cmd wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pickling a
TaskiqResultwhose exception needs a pickle-safe fallback currently replaceserroron the original result as well. For example, an exception class defined inside a function is replaced by an internal wrapper, so a subsequentraise_for_error()on the original result raises that wrapper.Copy the model's field mapping before preparing the serialized exception. The serialized fallback stays unchanged. The regression checks the round-trip error message and verifies that the original result still raises the same exception object.
Validation: 36 focused result/serialization tests passed, along with Ruff and Black on the changed files and MyPy over
taskiqandtests(144 files). The fullprekrun could not complete because Windows denied writing a hook dependency's temporary wheel; the full test suite and cross-platform CI matrix were not run.Prepared with AI assistance; the patch was independently reviewed and checked locally.