Repository navigation
feat(check): hide findings below error from human output in CI - #580
Merged
Merged
Conversation
When CI is true or 1, check prints only error-severity findings and counts the rest. --include-warnings brings them back. --json and the exit code are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CIistrueor1,taskless checkprints only error-severity findings and ends with a count of what it left out:When only warnings matched, it says
No errors found. …instead ofNo issues found., so a run that hid findings cannot read as a clean one.--include-warningsbrings them back.Decisions worth reviewing
--jsonis unchanged. Agents read it to confirm a rule fires, and some agent sandboxes setCI. Filtering there would return emptyresultsfor a warning rule that matched. The CI recipe uses human output.Test config
vite.config.tsnow setsCI: ""for the suite. Spawned CLIs inherit the runner'sCI=true, and four existing tests that assert on warning text failed under it before this change. The new tests passCIto the child explicitly. The full suite passes both with and withoutCI=truelocally.Fixes #568