Repository navigation
Test sending of paginated workflow task completions - #3178
Open
jmaeagle99 wants to merge 1 commit into
Open
jmaeagle99 wants to merge 1 commit into
jmaeagle99 wants to merge 1 commit into
Conversation
Quinn-With-Two-Ns
approved these changes
Oct 29, 2026
Cover the paginated send path in WorkflowWorker, which previously had no unit tests: intermediate pages are sent in order before the final page, a completion is sent whole when the namespace does not support pagination, buffer loss on any page resends every page from the first, other errors and worker shutdown end the resend loop, and the gRPC retryer never retries a lost buffer on its own.
jmaeagle99
force-pushed
the
wft-pagination-tests
branch
from
October 30, 2026 22:11
80f71e0 to
120d9a4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Added
WorkflowWorkerCompletionPaginationTest, which runs one workflow task through a realWorkflowWorkerwith a mocked service and checks everyRespondWorkflowTaskCompletedrequest:NOT_FOUNDfor a stale token) are not resent.own.
The harness waits until the task's slot is released before shutting the worker down, because shutdown ends the resend loop early.
Why?
The existing tests covered only
WorkflowTaskCompletionPaginator.paginate(). The send and resend logic inWorkflowWorkerhad no unit coverage, which is how the bug fixed in #3177 shipped. The integration test enabled by that PR covers only the success path.Checklist
How this was tested: Each test was checked against a deliberately broken send loop, and each one failed.
Any docs updates needed? No, test only.