Repository navigation
Cache images pulled by digest only in LocalImagesCache - #12131
Open
Chaitanya060 wants to merge 1 commit into
Open
Chaitanya060 wants to merge 1 commit into
Chaitanya060 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Index tags and digests core/src/main/java/org/testcontainers/images/LocalImagesCache.java, core/src/test/java/org/testcontainers/images/LocalImagesCacheTest.java |
populateFromList processes repository tags and digests. The new helper skips null arrays, filters names beginning with <none>, and caches distinct names. Tests cover images with a digest only, both a tag and digest, or neither. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: bsideup
Merge Risk: 
adb9a
-
The cache supports digest-only images, and the remaining combined-name case falls back correctly. No merge-blocking issue was found.
Pre-merge checks: 
-
Check name Status Explanation Resolution Description check The description contains only the standard template comments. It does not explain the changed behavior, the previous problem, the fix, or validation results. Add a brief description of the change. Explain the broken behavior, how LocalImagesCache now handles repository digests, and how the change was tested. Reference an issue if applicable. Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly identifies the main change: caching images pulled only by digest in LocalImagesCache. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit