Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Jackson versions and shaded metadata core/build.gradle, core/src/jarFileTest/java/org/testcontainers/JarFileShadingTest.java |
The build forces the three Jackson artifacts to version 2.18.12. The shaded JAR test expects Schubfach-LICENSE and FastDoubleParser-ThirdParty-LICENSE instead of the previous filenames. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Other
Suggested reviewers: eddumelendez, zachchuba
Merge Risk: 
Minimal · up to 6c856
-
This change updates the bundled Jackson libraries to a patched version and adjusts the matching JAR test. No actionable merge-blocking risk is identified, and CI should confirm the full build.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Description check
-
Explanation
The description clearly documents the issue, affected versions, implemented changes, related issues, verification results, and incomplete local checks. It provides the information required by the template.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Issue
Related to #9528. This addresses the Testcontainers 2.0.5 case reported in #11912, which was closed as a duplicate.
Problem
Testcontainers 2.0.5 embeds shaded Jackson 2.18.4 classes in the core JAR. A downstream dependency override cannot replace those relocated classes. The embedded version is within the affected range of CVE-2026-54512 and CVE-2026-54513, among other Jackson advisories.
Change
jackson-core,jackson-databind, andjackson-datatype-jsr310together at 2.18.12 in the core shaded build. Pinning core explicitly avoids mixing Jackson versions.JarFileShadingTestto match the META-INF resources in the Jackson-only rebuilt JAR.This branch is based on
mainand contains no Bouncy Castle version change; that is tracked separately in #12135.Verification
:testcontainers:dependencies --configuration shadedresolves Jackson core and databind at 2.18.12 while Bouncy Castle remains at 1.82.:testcontainers:build -x :testcontainers:test -x :testcontainers:spotlessJavaCheckpasses on the fork'smainbaseline, including compilation, shaded JAR tests, Checkstyle, Javadoc, and japicmp.git diff --checkpasses.The Docker integration suite has not completed locally: earlier runs hit Docker Model Runner and MCP gateway failures and an image-context streaming stall. The Java Spotless check could not run because
npmis unavailable on this host. CI should run the complete checks before merge.Summary by CodeRabbit