Skip to content

declare test-support on JAR dependency for tests - #12140

Open
codefish1 wants to merge 1 commit into
testcontainers:mainfrom
codefish1:build/test-support-jar-dependency
Open

codefish1 wants to merge 1 commit into
testcontainers:mainfrom
codefish1:build/test-support-jar-dependency

Conversation

@codefish1

@codefish1 codefish1 commented Oct 26, 2026 •

Copy link
Copy Markdown

Fixes #12136.

Problem

Gradle task validation reports that :test-support:test consumes the output of :test-support:jar without an explicit dependency. This can stop :test-support:build before the tests run.

Change

Declare jar as a dependency of the support module's test task in test-support/build.gradle. The change is confined to build task wiring.

Verification

  • :test-support:build -x :test-support:spotlessJavaCheck passes on the fork's main baseline, including the support module's tests.
  • :testcontainers:build -x :testcontainers:test -x :testcontainers:spotlessJavaCheck passes.
  • git diff --check passes.

The Java Spotless check requires npm, which is unavailable on this host. CI should run that check before merge.

Summary by CodeRabbit

  • Tests
    • The test task now builds the project JAR before running tests. This ensures the packaged artifact is available as part of the test workflow.

@codefish1
codefish1 requested a review from a team as a code owner October 26, 2026 17:06
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 02a632c0-7736-4793-bc13-4b4e52dccce8
Commits

Reviewing files that changed from the base of the PR and between f74d167 and badb2de.

Files selected for processing: 1
  • test-support/build.gradle

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

Walkthrough

The test-support Gradle configuration now makes the test task depend on the jar task.

Changes: Test-support build wiring

Layer / File(s) Summary
Declare the test task dependency
test-support/build.gradle
The test task now depends on the jar task.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: kiview, eddumelendez

Merge Risk: Minimal · up to badb2

No actionable merge-blocking issue was identified in this build-wiring-only change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely identifies the change: adding the test-support JAR as a dependency for tests.
Description check Passed The description explains the problem, identifies the build task wiring change, references issue #12136, and lists verification results and the unavailable npm-dependent check.
Linked Issues check Passed Issue #12136 requires explicit wiring from the test-support:test task to the test-support:jar task. test-support/build.gradle adds tasks.named('test') { dependsOn tasks.named('jar') }. This di…
Out of Scope Changes check Passed The reviewed diff changes only test-support/build.gradle. It adds the dependency required by issue #12136 and contains no unrelated production, test, or project changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #12136 requires explicit wiring from the test-support:test task to the test-support:jar task. test-support/build.gradle adds tasks.named('test') { dependsOn tasks.named('jar') }. This directly implements the requested Gradle validation fix. The reported build verification also covers the support-module tests.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: test-support build has an undeclared JAR task dependency

2 participants