Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 21, 2026 22:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
set_key()writes key names without the quoting accepted by the dotenv parser. Updating an existing'APP NAME'='old'entry returns success but writesAPP NAME='new', which cannot be read back. Names containing#or=are also corrupted. The CLI uses the same writer.Change
Quote names when required by dotenv syntax, independently of value
quote_mode. Keep ordinary unquoted names unchanged. Reject keys that this syntax cannot represent before opening or rewriting the target file. This does not add POSIX-shell export-name validation, which is separate from dotenv serialization.Regression tests cover creating and updating quoted keys, all three value quote modes, neighboring entries, ordinary names,
export=True, invalid keys with existing and missing files, and CLI round trips.Validation
Python 3.12.14:
tox -e lint,manifest,coverage-report: passed, including all five configured mypy targets.mkdocs build --strict, source/wheel build, andgit diff --check: passed.AI assistance was used to investigate, implement, test, and review this change.