Skip to content

Track the latest PHP image instead of a pinned version. #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustavofreze merged 2 commits into from
Oct 24, 2026
Merged

Track the latest PHP image instead of a pinned version. #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4737f6
chore: Point the PHP tooling image at its floating alias.
gustavofreze Oct 24, 2026
26b5704
fix: Unload bcmath through a copied scan directory, since the image c…
gustavofreze Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ TTY := $(shell [ -t 0 ] && echo -it)
HOST_USER := $(shell id -u):$(shell id -g)

PHP_VERSION := $(shell sed -n 's/.*"php": *"^\([0-9]*\.[0-9]*\)".*/\1/p' composer.json)
IMAGE_VERSION := 1.0.4
PHP_IMAGE := gustavofreze/php:${PHP_VERSION}-cli-${IMAGE_VERSION}
PHP_IMAGE := gustavofreze/php:${PHP_VERSION}-cli
WORKSPACE := /var/www/html
BCMATH_INI := $${PHP_INI_DIR}/conf.d/docker-php-ext-bcmath.ini
WITHOUT_BCMATH := cp -r $${PHP_INI_DIR}/conf.d /tmp/conf.d && rm /tmp/conf.d/docker-php-ext-bcmath.ini \
&& PHP_INI_SCAN_DIR=/tmp/conf.d

DOCKER_RUN = docker run ${PLATFORM} -u ${HOST_USER} --rm ${TTY} --net=host \
-e COMPOSER_HOME=/tmp/composer \
Expand Down Expand Up @@ -43,7 +43,7 @@ test-file: ## Run tests for a specific file (usage: make test-file FILE=ClassNam

.PHONY: tests-without-bcmath
tests-without-bcmath: ## Run unit tests on the pure PHP backend, with the extension unloaded
@${DOCKER_RUN} sh -c 'rm -f ${BCMATH_INI} && php ./vendor/bin/phpunit --configuration phpunit.xml --no-coverage tests'
@${DOCKER_RUN} sh -c '${WITHOUT_BCMATH} php ./vendor/bin/phpunit --configuration phpunit.xml --no-coverage tests'

.PHONY: review
review: ## Run lint and static analysis
Expand All @@ -58,7 +58,7 @@ show-outdated: ## Show outdated direct dependencies
@${DOCKER_RUN} composer outdated --direct

.PHONY: show-image
show-image: ## Show the pinned PHP tooling image
show-image: ## Show the PHP tooling image
@echo ${PHP_IMAGE}

.PHONY: clean
Expand Down