Repository navigation
Validate Byzantine leader proposals in Sailfish - #240
Merged
Merged
Conversation
Qian-Cheng-nju
force-pushed
the
sailfish-leader-validation
branch
from
October 20, 2026 17:24
9cede8b to
d0cb13b
Compare
Member
|
/cc ^^ @nano-o |
nano-o
reviewed
Oct 27, 2026
| else | ||
| with (delivered \in SUBSET {v \in vs : Round(v) = r-1}) { | ||
| await IsQuorum({Node(v) : v \in delivered}); \* ignored otherwise | ||
| if (Leader(r) = self) |
Contributor
There was a problem hiding this comment.
Between 129 and 130, add a comment that correct nodes check those conditions and ignore the message if they don't hold.
Contributor
Author
There was a problem hiding this comment.
Added a comment clarifying that correct nodes check these conditions and ignore the message if they don't hold.
nano-o
suggested changes
Oct 27, 2026
Signed-off-by: Qian-Cheng-nju <[email protected]>
Qian-Cheng-nju
force-pushed
the
sailfish-leader-validation
branch
from
October 27, 2026 12:51
d0cb13b to
449409f
Compare
Member
|
@Qian-Cheng-nju @nano-o Thanks for your efforts, ready to merge? |
Contributor
Author
I think it is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correct-leader path requires a reference to the previous leader, or a quorum of no-votes. The Byzantine path checks only that the parents form a quorum, so a Byzantine leader can publish a vertex that should have been rejected.
With four nodes and three-node quorums, a 16-transition replay violates
Agreement: correct nodes first commit<<a,1>>, but after the Byzantine round-2 leader omits that vertex without a no-vote certificate, nodealater replaces its log with one starting at<<d,1>>. Nodesbandcstill start with<<a,1>>.This adds the missing admission check to the Byzantine leader path and regenerates the PlusCal translation. It follows the implementation's header validation, which checks the no-vote certificate before storing a leader header without its predecessor.
The patched replay stops before the invalid proposal. Controls still admit a leader carrying its predecessor and one carrying a sufficient no-vote certificate.
TLCSailfish1passes with unchanged state counts, as do three additional small configurations before and after GST.