Skip to content

fix(build): strip leading .. from additionalFiles paths on Windows #5075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SimoMay wants to merge 1 commit into from
Closed

fix(build): strip leading .. from additionalFiles paths on Windows #5075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/additional-files-windows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/build": patch
---

`additionalFiles` now strips leading `..` segments on Windows too, so a pattern like `../shared/**` copies files inside the build instead of outside it.
4 changes: 2 additions & 2 deletions packages/build/src/internal/copyFiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { cp, copyFile, mkdir } from "node:fs/promises";
import { dirname, join, posix, relative } from "node:path";
import { dirname, join, posix, relative, sep } from "node:path";
import { glob } from "tinyglobby";

/**
Expand Down Expand Up @@ -44,7 +44,7 @@ export async function findFilesByMatchers(

const assets: CopyPair[] = files.map((file) => {
const pathInsideDestinationDir = relative(cwd, file)
.split(posix.sep)
.split(sep)
.filter((p) => p !== "..")
.join(posix.sep);
return {
Expand Down