Repository navigation
Serve stable server values from machine atoms - #241
Merged
Merged
Conversation
Memoize every bridge atom's server value on the identity of its inputs so repeated server reads return the same reference, and cache the server snapshot in the React result hook. React no longer warns that getServerSnapshot should be cached while hydrating MachineState. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01H9xMXPkpeqmvAbWNGY7R55
Contributor
Type performanceMeasured with TypeScript 6.0.3 and
Marginal instantiations are measured against the matching setup without that API call:
Check times (informational)
Type instantiations are the comparison metric. Check time varies with runner load and is informational only. |
Contributor
Runtime performanceMedian of 5 independent benchmark processes on Pull request baseline
Process runtime reference points
Effect Machine change from base
Process runtime reference change from base
Regression guardNo large, noise-adjusted throughput or heap regressions detected. Versions and interpretation
Higher throughput is better; lower heap is better. Variability is the median absolute deviation across independent processes, relative to their median. Small differences on shared GitHub-hosted hardware remain informational; the required guard rejects only large changes beyond the measured noise allowance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MachineState.snapshotand childsnapshot, and the source server values forresult, childresult, selectors (select*,matches*),can, and family projections. Repeated reads, including reads from different registries, return the same reference. Derived atoms stay stable because their sources are.useRetainedResultin@typeonce/effect-machine-reactcomputes its server snapshot once per store.can,familyandfamilyChildatoms, and a hydration assertion that React logs nogetServerSnapshotwarning. Both fail onmain.Changeset
Patch for
@typeonce/effect-machineand@typeonce/effect-machine-react.Validation
pnpm checkLocal
pnpm checknotes: dprint plugin downloads are blocked in the local sandbox, so formatting was checked with the same plugin versions loaded from npm.packages/devtools/test/StaticSite.test.tstimes out locally onmainas well; CI is authoritative.pnpm perf:runtimeran successfully as a smoke test.Generated by Claude Code