Repository navigation
chore: loosen json dependency to allow 3.x - #66
Merged
Merged
Conversation
Contributor
Author
Collaborator
|
Thank you for the contribution @erimicel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json 3 came out in September, but the
~> 2.9constraint in the gemspec stops apps from upgrading to it while they use this gem.The gem only calls
JSON.dumpandJSON.parsewith no options, and doesn't use any of the things json 3 removed. So I've loosened the constraint to>= 2.9, < 4.I ran the specs against a local Typesense 30.2 on both json 2.21.2 and json 3.1.0, and both are green (165 examples, 0 failures).
There's also a small second commit.
bundle exec rubocopcurrently fails on master, because CI picks up the latest RuboCop and its newStyle/DirectiveScopecop flags the disable/enable pair in the gemspec. I've switched it todisable-nextand raised the RuboCop floor to 1.90, where that directive was added. Happy to drop that commit if you'd rather sort it out separately.PR Checklist