Repository navigation
Conversation
mnoah1
marked this pull request as ready for review
October 27, 2026 22:49
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 27, 2026 22:49
mnoah1
marked this pull request as draft
October 27, 2026 22:49
mnoah1
marked this pull request as ready for review
October 27, 2026 22:52
mnoah1
changed the title
## Summary Register the fix consumer in the reference host with an extended retry subscription. Use a no-op repair executor that returns `noop/<buildID>` without launching work. The fix controller records the usual one-per-build association. Fix dead-letter recovery consumer registration remains separate. ## Test Plan Run ./tool/bazel test //service/stovepipe/server:go_default_test //stovepipe/controller/issuetrack:go_default_test //stovepipe/controller/fix:go_default_test //stovepipe/core/fixrequest:go_default_test //test/integration/stovepipe:go_default_test --test_output=errors. The Docker/MySQL integration suite starts the reference server with the new subscription, and the wiring test exercises no-op acceptance through the registered fix controller. ## Revert Plan Revert this PR to stop the fix consumer and remove the no-op executor. No schema changes are required. ## Issue Links None — reference-host fix wiring with no associated ticket.
mnoah1
force-pushed
the
mnoah1/stovepipe-issue-fix-wiring
branch
from
October 29, 2026 14:38
b641439 to
00d3db9
Compare
mnoah1
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Register the fix consumer in the reference host with an extended retry subscription.
Use a no-op repair executor that returns
noop/<buildID>without launching work. The fix controller records the usual one-per-build association. Fix dead-letter recovery consumer registration remains separate.Test Plan
Run ./tool/bazel test //service/stovepipe/server:go_default_test //stovepipe/controller/issuetrack:go_default_test //stovepipe/controller/fix:go_default_test //stovepipe/core/fixrequest:go_default_test //test/integration/stovepipe:go_default_test --test_output=errors. The Docker/MySQL integration suite starts the reference server with the new subscription, and the wiring test exercises no-op acceptance through the registered fix controller.
Revert Plan
Revert this PR to stop the fix consumer and remove the no-op executor. No schema changes are required.
Issue Links
None — reference-host fix wiring with no associated ticket.