Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The
gitworkspacecontract leaves git identity and global options to the backend, but the local backend runsgitfromPATHwith the caller's environment and has no committer. The git merger can't move onto a workspace until the local backend runs git the way the merger does today.What?
local.ParamsgainsRuntimeandCommitterName/CommitterEmail.gitcommands then run on the pinned runtime with the scrubbed environment and the injected committer. A zeroRuntimekeeps today's behavior.NewFactoryreturns an error for an invalid runtime or a half-set committer. The orchestrator's Tango workspace is updated for the new signature.Test Plan
bazel test //platform/extension/gitworkspace/... //service/submitqueue/orchestrator/server/...Issue