Repository navigation
Conversation
## Why? After record-stage work was abandoned, project_results_complete stayed false and the UI continued to report that project result recording was in progress. ## What? Project record_abandoned events into the existing completion timestamp. Preserve the first projected completion time and any recorded facts and project counts; keep project_facts_recorded distinct from abandonment. Cover event replay, concurrent projection updates, and empty or partial results through both status endpoints. Existing abandoned requests require replaying their retained abandonment event after rollout to repair the summary. ## Test Plan Passed the request-log, record-controller, and RPC-controller unit tests and the Docker-based Stovepipe integration suite. Also passed make fmt, make lint, make check-tidy, and make check-gazelle. ## Issue None.
mnoah1
marked this pull request as ready for review
October 29, 2026 14:36
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 29, 2026 14:36
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
After record-stage work was abandoned, project_results_complete stayed false and the UI continued to report that project result recording was in progress.
What?
Project record_abandoned events into the existing completion timestamp. Preserve the first projected completion time and any recorded facts and project counts; keep project_facts_recorded distinct from abandonment. Cover event replay, concurrent projection updates, and empty or partial results through both status endpoints.
Existing abandoned requests require replaying their retained abandonment event after rollout to repair the summary.
Test Plan
Passed the request-log, record-controller, and RPC-controller unit tests and the Docker-based Stovepipe integration suite. Also passed make fmt, make lint, make check-tidy, and make check-gazelle.