Repository navigation
Run a single SQL benchmark from CI - #10996
Open
joseph-isaacs wants to merge 1 commit into
Open
joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
Add `vx-bench matrix <preset> --only <ids>` to narrow a preset to some benchmark IDs, thread a `benchmarks` input through the SQL benchmark workflows, and dispatch `action/bench-sql/<id>` labels to run one benchmark (e.g. `action/bench-sql/polarsignals`) at its pr-all coverage. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01UeniBBEDeQ2eX7jrUkhKkU Signed-off-by: Joe Isaacs <[email protected]>
Merging this PR will improve performance by 13.15%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Benchmarking one SQL suite on a PR (e.g. PolarSignals) currently means running a whole preset via
action/bench-sql*. This adds a per-benchmark label and a workflow input so you can run just the benchmarks you need.Changes
vx-bench matrix <preset> --only <ids>: narrows a preset to the given benchmark IDs (comma- or space-separated), keeping the preset's order and coverage. Empty input keeps the whole preset. An ID the preset doesn't schedule is an error that lists the IDs it does.action/bench-sql/<id>labels (pr-bench-dispatch.yml): one generic job matches any label with this prefix, removes it, strips the prefix and runs that benchmark at itspr-allcoverage, e.g.action/bench-sql/polarsignals. The label reaches the shell only through an env var.benchmarksinput onpr-bench-sql.yml(workflow_call+workflow_dispatch) andsql-bench-matrix.yml, passed to--only. The concurrency group now includes it, so a single-benchmark run doesn't cancel a full run of the same preset.docs/developer-guide/benchmarking.mdandbench-orchestrator/README.md.The labels must exist before they can be added. Valid IDs are the ones
vx-bench matrix pr-allprints:clickbench-nvme clickbench-sorted-nvme tpch-nvme tpch-s3 tpch-nvme-10 tpch-s3-10 tpcds-nvme statpopgen fineweb fineweb-s3 polarsignals appian-nvme job-nvme vortex-queries. To create them:Testing: new tests in
bench-orchestrator/tests/test_matrix.pycheck that every ID in every preset can be selected on its own, plus ordering, empty selection, unknown-ID rejection and the CLI separators.pytest bench-orchestrator/tests(47 passed),ruff format --check,ruff check,yamllint --strictandtyposare clean.actionlintwas not run, and the label path hasn't run in real CI yet.Generated by Claude Code