Skip to content

Reduce syscall noise in Python scan benchmarks - #10998

Merged
connortsui20 merged 1 commit into
developfrom
ct/python-scan-simulation
Oct 29, 2026
Merged

connortsui20 merged 1 commit into
developfrom
ct/python-scan-simulation

Conversation

@connortsui20

Copy link
Copy Markdown
Member

Summary

The CodSpeed report on #10990 flags test_scan[int_str] as dominated by system calls. Its trace attributes about 314 ms to condition-variable wakeups under the async I/O reactor.

Changes

Runs Python CPU simulation with VORTEX_MAX_THREADS=0 and memory-maps the shared benchmark files, so scans execute on the calling thread without dispatching file reads to I/O threads. This changes the scan, filter, and scalar-access benchmark setup, including repeated scans.

Pre-commit formatting and sign-off checks passed. Workspace Clippy was started by the push hook and interrupted. Tests and CodSpeed have not been rerun, so clearing the warning still needs CI confirmation.

@codspeed

codspeed Bot commented Oct 29, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 11.23%

1 warning

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚡ 2 improved benchmarks
✅ 2304 untouched benchmarks
🗄️ 47 archived benchmarks run1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Walltime threshold_avx2[80] 3 µs 2.7 µs +12.39%
⚡ CPU Simulation test_repeated_scan_scalar_at[int_float] 308.3 µs 280 µs +10.08%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/python-scan-simulation (55028ca) with develop (c6d6bad)

Open in CodSpeed

Footnotes

  1. 47 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them. ↩

@robert3005 robert3005 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for simulation this makes sense

@connortsui20
connortsui20 merged commit ff21cb1 into develop Oct 29, 2026
113 of 114 checks passed
@connortsui20
connortsui20 deleted the ct/python-scan-simulation branch October 29, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants