Repository navigation
Reduce syscall noise in Python scan benchmarks - #10998
Merged
Merged
Conversation
Signed-off-by: Connor Tsui <[email protected]>
Merging this PR will improve performance by 11.23%1 warning
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
robert3005
approved these changes
Oct 29, 2026
robert3005
left a comment
Contributor
There was a problem hiding this comment.
I think for simulation this makes sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CodSpeed report on #10990 flags
test_scan[int_str]as dominated by system calls. Its trace attributes about 314 ms to condition-variable wakeups under the async I/O reactor.Changes
Runs Python CPU simulation with
VORTEX_MAX_THREADS=0and memory-maps the shared benchmark files, so scans execute on the calling thread without dispatching file reads to I/O threads. This changes the scan, filter, and scalar-access benchmark setup, including repeated scans.Pre-commit formatting and sign-off checks passed. Workspace Clippy was started by the push hook and interrupted. Tests and CodSpeed have not been rerun, so clearing the warning still needs CI confirmation.