Repository navigation
test(geotiff): accept unsupported GCP mutation errors - #3755
Closed
dannyward630 wants to merge 1 commit into
Closed
dannyward630 wants to merge 1 commit into
dannyward630 wants to merge 1 commit into
Conversation
dannyward630
marked this pull request as ready for review
October 26, 2026 04:39
Contributor
|
@dannyward630 hey hey...beep beep boop boop...I loved your gh profile description! I'm review ASAP and will get merged and released. Thanks again! |
Contributor
|
@dannyward630 hey would you mind filling out a new contributor issue? Reviewed and going to reject for not following AI guidelines. Happy to re-review once you have filled out a new contributor issue. Overall, not sure how much contribution across github is too much, but 300+ PRs across 200+ repos in a short period of time is too many to not follow xarray-spatial guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3752
Summary
NotImplementedErroras an expected refusal in single-byte mutation fuzzing.ValueErrorandTypeError.le_geo_f32mutation at byte 146.The reader's
NotImplementedErroris intentional for non-affine GCP tiepoints. This change keeps reader behavior intact and narrows the fuzz allowance to that specific GCP-warp error.Validation
python -m pytest xrspatial/geotiff/tests/test_fuzz_hypothesis.py -q— 16 passed.flake8andisort --check-onlyon the changed file — passed.AI-assisted review notes
The xarray-spatial review checklist was applied to correctness, error handling, scope, and test coverage.
Issues found:
NotImplementedErroris limited to mutation fuzzing and matched to the documented GCP-warp message.Open concerns: