Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
format_path()uses a string prefix to decide whether a path is insideHOME. WithHOME=/home/user,/home/username/fileis rendered as~/../username/file, even though it is not inside the home directory. The documented abbreviation is intended for the home directory and its descendants.Change
Require either an exact home-directory match or a prefix ending at a path separator. Preserve normalization, trailing separators, exact-home rendering and filesystem-root homes. The implementation keeps the project's older Python compatibility rather than using
os.path.commonpath.Tests
git diff --check, wheel and sdist passed.Python 2, older Python versions, Windows and macOS were not tested locally. Hosted CI has not been verified green. No test or CI configuration changed.