[gouarin]

Checklist

• The title and commit message(s) are descriptive.
• Small commits made to fix your PR have been squashed to avoid history pollution.
• Tests have been added for new features or bug fixes.
• API of new functions and classes are documented (no public API changes).

Description

argsort with sorting_method::quick, the default, ran std::sort and then fell through into the stable case, so every call also ran std::stable_sort on the already sorted indices. The result was still valid, but the work was done twice. GCC reports it with -Wimplicit-fallthrough.

Both cases of the switch in detail::argsort_iter now end with break.

xsort.argsort_quick_sorts_once counts the comparisons made by argsort_iter with the quick method and checks they match a single std::sort on the same data: 108 on master against 70.

[codspeed]

Merging this PR will not alter performance

1 warning

⚠️ Unable to measure the execution of 1 benchmark

This benchmark measured no execution time, so its result is not comparable and counts as unchanged. This usually happens when the compiler removes the code under test.

Prevent compiler optimizations

See affected benchmarks

✅ 255 untouched benchmarks

---

_{Comparing gouarin:fix-argsort-quick (f5dc73f) with master (57f3d07)}