Repository navigation
Conversation
The xtensor_fixed.buffer_adaptor test multiplied an adapted row by a default constructed xtensor_fixed. Like std::array, xtensor_fixed does not initialize its elements, so the test read indeterminate values and checked nothing. GCC 13 at -O3 reports the read as -Wmaybe-uninitialized in the multiplies operator, and in xcontainer::load_simd when XTENSOR_USE_XSIMD is defined. The operand is now initialized, the buffer starts at ones so the product is visible, and the test checks the result.
Contributor
Merging this PR will not alter performance1 warning
Comparing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
xtensor_fixed.buffer_adaptormultiplied an adapted row by a default-constructedxtensor_fixed:GCC 13 at
-O3reports this read as-Wmaybe-uninitializedin themultipliesoperator, and inxcontainer::load_simdwithXTENSOR_USE_XSIMD. The warning is right: the bug is in the test, not in the library.The operand is now initialized, the buffer starts at ones so the product shows, and the test checks the result.
test_xfixedcompiles without these warnings with GCC 13-O3, with and without xsimd.