Repository navigation
Upgrade to .NET 10, runner images to windows-2025, use only 26100 Windows SDK - #885
Merged
Merged
Conversation
…lable" This reverts commit aa305f0.
…0 upgrade is complete
Use commit 0b619e9e9f10222b5857dc3a0bedb3870ee901de from CommunityToolkit/Tooling-Windows-Submodule#315 for end-to-end validation before merging. Co-authored-by: Copilot App <[email protected]>
Pin tooling to the latest commit from CommunityToolkit/Tooling-Windows-Submodule#315 and match its .NET SDK version. Co-authored-by: Copilot App <[email protected]>
Remove test children through their owning collection instead of recursively disconnecting the TextBox template. Recursive disconnection causes a delayed native fail-fast in WinUI TextBoxView teardown, aborting later unrelated tests. Keep the weak-reference collection assertion intact. Co-authored-by: Copilot App <[email protected]>
Remove the Release-only NuGet.Build.Tasks.Pack 6.12.1 pin. The old pack task misreads the alias-keyed assets produced by NuGet 7 restore, dropping implicit mobile platform versions and failing both package jobs with NU1012. Let the .NET SDK provide compatible restore and pack tasks. Co-authored-by: Copilot App <[email protected]>
2 of 11 tasks
Sergio0694
enabled auto-merge (squash)
October 27, 2026 00:00
Arlodotexe
requested changes
Oct 27, 2026
Member
There was a problem hiding this comment.
Please don't recreate all the commits manually by hand, even if they're 1:1 identical and have re-added attribution as co-author. It breaks the timeline of commit history and makes future investigations much harder. Instead, just reapply the commits from the PR we re-opened this from (e.g. set the branch to the right hash and force-push).
Sergio0694
force-pushed
the
user/sergiopedri/refresh-net-10-pr
branch
from
October 27, 2026 00:27
6e45ffb to
bd6d1ef
Compare
Arlodotexe
disabled auto-merge
October 27, 2026 00:30
Arlodotexe
enabled auto-merge (rebase)
October 27, 2026 00:30
Arlodotexe
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Replaces the closed #852 with the same changes on a separate branch, so GitHub can create fresh checks instead of retaining the stale external Testspace status. This is a PR recreation, not a new issue fix or a change to Testspace configuration. The branch points directly to #852's original head,
bd6d1efeccaea972b6d84d8d89707b8ab74f728c: all 20 original commit objects, hashes, authors, timestamps, messages, and parent relationships are preserved without cherry-picking or rewriting them.PR Type
What kind of change does this PR introduce?
What is the current behavior?
The original #852 was blocked by stale external Testspace reporting. At the original branch point, the root SDK is .NET 9, the Windows CI jobs use
windows-2022, and Release builds pinNuGet.Build.Tasks.Pack6.12.1. The old TextBox lifetime test recursively disconnects its visual tree, which can cause delayed native teardown failures.What is the new behavior?
The final diff is identical to #852: six files changed, 9 insertions and 11 deletions.
10.0.402and tooling commitf02adf9e2d1ec1fd4865116bc786e217298985affrom the merged CommunityToolkit/Tooling-Windows-Submodule#315, including its Windows SDK 26100 configuration.windows-2025for XAML styling andwindows-2025-largefor the Windows build, package, and signing jobs. Rely on the runner's inbox Windows SDKs; no ISO-based SDK installer is added.uno.checkto1.34.1and SlnGen to12.0.32.No additional implementation or Testspace changes are introduced by this recreation. The original PR stays closed and its branch remains unchanged.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
This is a separate feature branch in the upstream repository, not a fork. No new components, source files, or tests are added beyond the original changes; the corresponding checklist items are not applicable.
The original history has been restored directly as requested in review. Its branch point is
34a57f969bf7966e0a3cbe9d4d10a47758d097a0.mainhas since advanced to25567617499ca5e5bd82fc0414a5b7aed29c12bc; the original commits have not been rebased or merged with those later changes.Validation performed after restoring the original history:
git rev-parse HEAD origin/pr852-source— passed; both resolve to the original headbd6d1efeccaea972b6d84d8d89707b8ab74f728c.git rev-list --reverse 34a57f969bf7966e0a3cbe9d4d10a47758d097a0..HEADand the same command usingorigin/pr852-source— passed; all 20 commit hashes match in order, not merely their patches.git diff --exit-code bd6d1efeccaea972b6d84d8d89707b8ab74f728c HEAD— passed; identical final tree,5cd3e627d8e26d3a466a8a419d5e7f41fb412375.git ls-remote origin refs/heads/user/sergiopedri/refresh-net-10-pr— passed; remote branch points to the original head. GitHub also confirms this PR's head and its 20 commits, six changed files, 9 insertions, and 11 deletions.git status --porcelain— passed; clean worktree.The documented build/test workflow in
ReadMe.mdand.github/workflows/build.ymlwas inspected. Builds and tests were not rerun locally for this history-only correction; no new CI success is claimed.